1.8 diskio.flush_files not working

[begemote]

I've noted recently that Procmon/Filemon doesn't show *CLOSE operations on completed downloads under 1.8 (build 11813). Further study confirms that files stay constantly opened, thus ignoring diskio.flush_files=true in my settings. 1.7.7 has no problems with that.

EDIT:

It is related to upload speed. When speed dropped below 100kb/s closes reappears.

[Greg Hazel]

It is possible that enough read or write operations could postpone a close operation indefinitely, but this is not new to 1.8.

[begemote]

alus, thank You for reply. I've spend more than 6 hours trying to reproduce this issue with different versions You gave me and I can only success with utorrent-1.8-beta-10770.exe in 2 of 4 runs. This was happen with FASTIO_READ requests 131072 bytes in length without interspersing IRP_MJ_READs or FASTIO_READs 16384 bytes in length. I've also noted that upload speed raised very quickly from 0 to ~400kB/s.

uT advanced cache settings: all checks on except "disable windows caching of disk reads", "turn off read caching if the upload is slow", "increase automatic cache size when cache thrashing". win xp sp2, 2gb ram, intel core2duo 2.6ghz. I've saved filemon's log, but it isn't very interesting. Enabling read caching on slow upload was done only to simplify testing, because it was on when I first encounter this issue.

...
2846    05:23:38.062    utorrent.exe:1892   IRP_MJ_CREATE   E:\download\torrent\wait\some-dir\another-data.rar   SUCCESS Options: Open  Access: Read 
2847    05:23:38.062    utorrent.exe:1892   IRP_MJ_READ     E:\download\torrent\wait\some-dir\another-data.rar   SUCCESS Offset: 262207925 Length: 131072    
2848    05:23:38.062    System:4    IRP_MJ_CLOSE    E:\download\torrent\wait\some-dir\another-data.rar   SUCCESS     
2849    05:23:38.156    utorrent.exe:1892   FASTIO_READ E:\download\torrent\wait\some-dir\another-data.rar   SUCCESS Offset: 262863285 Length: 131072    
...
2858    05:23:54.015    utorrent.exe:1892   IRP_MJ_CREATE   E:\download\torrent\wait\some-dir\data.rar    SUCCESS Options: Open  Access: Read 
2859    05:23:54.015    utorrent.exe:1892   IRP_MJ_READ     E:\download\torrent\wait\some-dir\data.rar    SUCCESS Offset: 39516775 Length: 131072 
2860    05:23:54.015    System:4    IRP_MJ_CLOSE    E:\download\torrent\wait\some-dir\data.rar    SUCCESS     
2861    05:23:54.031    utorrent.exe:1892   FASTIO_READ E:\download\torrent\wait\some-dir\another-data.rar   SUCCESS Offset: 360511925 Length: 131072    
...
2871    05:24:00.781    utorrent.exe:1892   FASTIO_READ E:\download\torrent\wait\some-dir\another-data.rar   SUCCESS Offset: 63764917 Length: 131072
2872    05:24:01.375    utorrent.exe:1892   FASTIO_READ E:\download\torrent\wait\some-dir\data.rar    SUCCESS Offset: 39647847 Length: 131072
2873    05:24:01.656    utorrent.exe:1892   FASTIO_READ E:\download\torrent\wait\some-dir\another-data.rar   SUCCESS Offset: 209254837 Length: 131072    
...

IOW it first opens a file, read it one time, then closes, but continues to read it afterwards. Moreover, process explorer shows one valid (and unchanged) file handle for each mentioned file.

Hope this helps. Thank You for excellent work.

[Greg Hazel]

Well, if it happens in 10770 it should happen in earlier versions too.